Add nikic/php-parser v5 support

[VincentLanglet]

No description provided.

[edsrzf]

I ran this over a code base that's still using php-parser 4. There's a problem with usePHPParserV4, which I've commented on, but with that fixed it seems to work.

Do we need to look at running tests against php-parser 4 as well?

[VincentLanglet]

I ran this over a code base that's still using php-parser 4. There's a problem with usePHPParserV4, which I've commented on, but with that fixed it seems to work.

Do we need to look at running tests against php-parser 4 as well?

Thanks. I added the CI "lowest" with php parser 4 and fixed the build.

[VincentLanglet]

I think this i ready to be review @orklah @weirdan

[SCIF]

👍

[chriskapp]

It would be really nice if we could merge this, currently it is not possible to install Psalm with PHPUnit 11 since it requires nikic/php-parser: ^5.0

[VincentLanglet]

Friendly ping @weirdan if you have time to take a look (or can ping another maintainer ?).
This PR would be really helpful, by allowing to use both Psalm and PHPunit 11.

[weirdan]

Yeah, it's on my todo list. The thing is big, so it'll take me some time.

[weirdan]

Since we expose parts of PhpParser in our API this cannot go into 5.x line. So instead of merging this I'm going to fork 6.x from the current 5.x (not master) and then use this PR as a base for PhpParser 5.x upgrade. 6.x will be a transitional, hopefully short-lived, series with the same platform requirements as 5.x.

Thanks for all your work, this will make it easier.

[ghostwriter]

If the branch-alias in the master branch is preventing you from using the 6.x branch (causing it to pull the master branch instead of referencing the correct commit from the 6.x branch), add #{commit_sha} to specify the correct branch.

For example:

"vimeo/psalm": "6.x-dev#0f796f1"

Replace 0f796f1 with the latest commit SHA for accurate results.

[bensinclair]

Any update on this? I'm unable to install vimeo/psalm due to not support version 5 of nikic/php-parser.

[edsrzf]

In addition to the dependency conflicts with various packages, nikic/php-parser 5 is required to parse new PHP 8.4 features: property hooks and asymmetric visibility.

PHP 8.4 releases in about a week. Currently Psalm is unable to parse these constructs, let alone type check them, so Psalm users will be blocked from adopting these new language features.

[WyriHaximus]

In addition to the dependency conflicts with various packages, nikic/php-parser 5 is required to parse new PHP 8.4 features: property hooks and asymmetric visibility.

PHP 8.4 releases in about a week. Currently Psalm is unable to parse these constructs, let alone type check them, so Psalm users will be blocked from adopting these new language features.

It's this + that it's blocking anything else using nikic/php-parser 5 from being used with Psalm in the same package. PHPStan v2 and many more at this point.