-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Web.JSON improve to v8 #695
base: master
Are you sure you want to change the base?
Conversation
From my point of view, at least this module should keep backward compatibility while
|
Vital.vim is currently (basically) support vim 8.0 or later.
I'm thinking of an implementation that makes the JSON module more flexible like Python's JSON Library.
Agree One thing, These are purely bug fixes.
|
Yeah, I think so but it's just my opinion. Actually, I'm more welcome to remove this module rather than improve/fix because of existnace of
Got it. Well, then I think it's better to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Think Changes OK.
But. If you review result read and think to need changing.
- Vim.Type use or not
- add Changes
項目がのこったままになってる面があったので、レビューがんばってみました。
(ありすえさん指摘の点をどうするかは別として、内容自体は問題ないと思います。(自信は微妙ですが))
そのまますすめるにしても、指摘点についてどうするか確認の意味もあり、 Request changes
で返しています。
corresponding javascript tokens (e.g. 'true'). | ||
Otherwise 1 or 0 are used to represent these. | ||
The default value is 0. | ||
'allow_nan' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This point is incompatible changing. need appending item to Changes
.
Please Changes
appending to commit after all changes are done, and before PR merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the point you say Add 'allow_nan' or Remove 'use_token'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
I think, Adding phrase to Changes
for example Improve and *use_token* remove, and option renewal to support *allow_nan*
.
I'm created #743 that part of bug fixes of this PR. |
Closed by #743 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late. I think it would be better to add a new one like Data.JSON
or whatever and mark this module obsolete but while the code seems OK, approved 👍 I don't care if this PR is merged as-is if others do not care about my point of view.
Web.JSON
is too old.Update to vim 8.
...But since
json_encode()
already exists, is this module unnecessary?This PR includes these new featues.