Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync/atomic alignment fix #197

Merged
merged 2 commits into from
Aug 29, 2023
Merged

sync/atomic alignment fix #197

merged 2 commits into from
Aug 29, 2023

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Aug 28, 2023

What changed

  • This changes the position of streamIDCounter so it has a 64-bit offset

Why

  • On 32-bit arm systems, sync/atomic will panic on this field

Lint failure

These only show up when you run the linter on 32-bit arm hardware, but the message looks like this:

rpc/wrtc_client_channel.go:241:7: SA1027: address of non 64-bit aligned field streamIDCounter passed to sync/atomic.AddUint64 (staticcheck)
                Id: atomic.AddUint64(&ch.streamIDCounter, 1),
                    ^

The rdk repo will soon check all of its dependencies for these lint failures.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ abe-winter
❌ Abe Winter


Abe Winter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@abe-winter abe-winter added the safe to test Mark as safe to test label Aug 29, 2023
@viambot viambot removed the safe to test Mark as safe to test label Aug 29, 2023
@github-actions
Copy link

For security reasons, this PR must be labeled with safe to test in order for tests to run.

@abe-winter abe-winter added the safe to test Mark as safe to test label Aug 29, 2023
@abe-winter abe-winter merged commit cf09251 into main Aug 29, 2023
7 checks passed
@abe-winter abe-winter deleted the 32-bit-atomic branch August 29, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Mark as safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants