Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase hugeparam default size #965

Merged
merged 3 commits into from
Oct 22, 2024
Merged

increase hugeparam default size #965

merged 3 commits into from
Oct 22, 2024

Conversation

HaoYang0000
Copy link
Collaborator

The new linter version breaks unit test because of the hugeParam size

@HaoYang0000 HaoYang0000 changed the title disable hugeparam increase hugeparam default size Oct 22, 2024
@HaoYang0000 HaoYang0000 marked this pull request as ready for review October 22, 2024 13:17
@roypaulin
Copy link
Collaborator

Let's instead use pointers in verticadb_conversion.go. Like in Cai's PR. Can you update it here?

@HaoYang0000
Copy link
Collaborator Author

Let's instead use pointers in verticadb_conversion.go. Like in Cai's PR. Can you update it here?

Yeah, updated in aca9bb9

roypaulin
roypaulin approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@roypaulin roypaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will merge it once all the tests pass.

@roypaulin roypaulin merged commit b5e8a73 into main Oct 22, 2024
37 checks passed
@roypaulin roypaulin deleted the fix-lint-issue branch October 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypaulin roypaulin roypaulin approved these changes

@cchen-vertica cchen-vertica Awaiting requested review from cchen-vertica cchen-vertica is a code owner

@fenic-fawkes fenic-fawkes Awaiting requested review from fenic-fawkes fenic-fawkes is a code owner

@qindotguan qindotguan Awaiting requested review from qindotguan qindotguan is a code owner

@LiboYu2 LiboYu2 Awaiting requested review from LiboYu2 LiboYu2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoYang0000 @roypaulin