This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
feat(DownloadManager): properly handle downloading #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently in-progress download notifications don't do anything when clicking them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the download manager to properly handle all possible download states, and cancel/clean up after itself properly (previously it could get in a stuck state and hang a thread forever, lagging the device from download state queries every millisecond)
Additionally, this handles the event the download was cancelled through a coroutine cancellation, and cancels the download subsequently and cleans up after itself (so the entire installation process will not go on now either)
Could possibly be a fix for #50 as well