Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test asserts #831

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

alexandear
Copy link
Contributor

Description

The PR refactors tests by simplifying asserts: swap actual-expected parameters, use assert.Len, assert.Greater etc. Additionally, enables testifylint to suggests these in a future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Run unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp LandonTClipp merged commit f9da2b6 into vektra:master Oct 22, 2024
4 checks passed
@alexandear alexandear deleted the refactor/test-asserts branch October 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants