-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Drop support for Python 3.8
#3647
Conversation
These should be the first supported versions our min python
Only required 2 manual fixes #3497
The CI error is a bit cryptic, but I think #3494 was due to similar error @MarcoGorelli if you're available, I just wanted to run this by you in case you can spot the issue in https://github.com/vega/altair/actions/runs/11438192791/job/31819284620?pr=3647 I think it is this line, but quite unsure why this has become an issue here altair/tests/vegalite/v5/test_api.py Line 34 in 61f1db7
UpdateFixed in test: Try invoking |
Won't fix ci issue, but these are no longer needed https://github.com/vega/altair/actions/runs/11438192791/job/31819285124?pr=3647
Not sure how to unblock the expected checks for:
They were removed in |
#3647 (comment) Screenshot from that PR (@binste)I still don't have the permissions for viewing/editing these rules - so I'll need some help updating them if anyone is available? |
I've removed the rules in the rule set for Python version 3.8. All checks are now green, is that in line what is expected? I did not look careful if the CI in this PR was still red before I made the change to the ruleset. |
Thanks @mattijn It was all green except, with the two |
Is pandas version 1.1.3 the minimum supported version for Python 3.9? |
That was the earliest I found going through the release notes @mattijn
I think |
Thanks! Moving forward🥳 |
Closes #3497
Note for reviewers
Most of the changes in this PR were handled by
ruff
, and relate to these3.9
changes:Essentially, this looks like a big job but excluding (c765897) this is actually quite a minor PR
Tasks
build.yml
, minimumpandas
,numpy
(da300c3)pyproject.toml
(c694f65)ruff
and fix errors (c765897)alt.themes
->alt.theme
#3618 (comment))3.9
error foribis
(5995202)hatch test --python 3.9