Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host_metrics source): Implement process collection for host metrics #21791

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LeeTeng2001
Copy link

@LeeTeng2001 LeeTeng2001 commented Nov 14, 2024

Summary

Implement process metric collection for host metrics souce

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

A simplistic vector config for testing, additionally, it has unit test written in similar style to other host metrics

[sources.host]
type = "host_metrics"
collectors = ["process"]

[sinks.my_sink_id]
type = "console"
encoding.codec = "json"
inputs = ["host"]

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

#9626

@LeeTeng2001 LeeTeng2001 requested a review from a team as a code owner November 14, 2024 05:23
@bits-bot
Copy link

bits-bot commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Nov 14, 2024
@LeeTeng2001 LeeTeng2001 changed the title feat(source): Implement process collection for host metrics feat(host_metrics source): Implement process collection for host metrics Nov 14, 2024
@pront
Copy link
Contributor

pront commented Nov 15, 2024

Thanks @LeeTeng2001! There a few failing CI checks. cargo fmt should fix them.

See how to run common checks locally here: https://github.com/vectordotdev/vector/blob/master/CONTRIBUTING.md#running-other-checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants