conway: tx body items #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmazak
force-pushed
the
conway-keys
branch
from
db46a14
to
7a4f63c
Compare
janmazak
force-pushed
the
conway-txbody
branch
from
f70cae9
to
87b160c
Compare
janmazak
force-pushed
the
conway-keys
branch
from
7a4f63c
to
4386a51
Compare
davidmisiak
reviewed
Dec 15, 2023
Comment on lines
+740
to
+741
| "Always", | ||
| "abstain", |
There was a problem hiding this comment.
Also here? (e.g. the current Trezor implementation displays Delegating to: Abstain)
There was a problem hiding this comment.
I'd keep this one because it describes what will happen (as a consequence of this delegation).
For UI details, there is no one that would give us some definitive guidance, everyone just suggests this and that and I can't evaluate the proposals due to lack of information. So at this point, we want to put something out (on experimental provider) and let SW wallets & M. Lang try it and then gather feedback.
There was a problem hiding this comment.
Ok, let's do it consistently on Trezor then.
cc @jaskp (only changing the string in UI should be sufficient)
janmazak
force-pushed
the
conway-txbody
branch
3 times, most recently
from
8b6bf5c
to
b479eea
Compare
janmazak
force-pushed
the
conway-txbody
branch
5 times, most recently
from
c6352df
to
c95aece
Compare
davidmisiak
approved these changes
Dec 18, 2023
janmazak
force-pushed
the
conway-txbody
branch
from
6ea0a18
to
9bfbb88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificates, voting procedures, treasury, donation.