Parvatijay2901/update signup_and_login_botton_color #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parvatijay2901
requested review from
lsetiawan and
nikiburggraf
as code owners
lsetiawan
reviewed
Oct 17, 2024
| errorMessage: errorMessage ?? this.errorMessage, | ||
| showPassword: showPassword ?? this.showPassword, | ||
| ); | ||
| } | ||
|
|
||
| // Check if all fields are filled | ||
| bool checkAllFieldsFilled() { |
There was a problem hiding this comment.
This check is more of a business logic and I think it is best practice to place this within the cubit instead of the state. The logic would be that this check should run against the current state. You'd need some sort of event that emits a change in this isAllFieldsFilled.
- You can use a bloclistener (https://bloclibrary.dev/flutter-bloc-concepts/) on the login form / signup form to check what the current state is
- From there you can either modify the state by emitting an event or simply keeping track of just the button state within the widget
* test: setup CI and framework for unit tests * style: update dummy test * test: authService signUp codes tests * test: add build_runner for mocking test classes in CI testing * ci: run workflow only for frontend changes * docs: add description for test group and setup
|
MultiBlocListener reference: felangel/bloc#3155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
isAllFieldsFilledproperty and acheckAllFieldsFilledfunction to theSignupStateandLoginStateclasses to make sure the app can check if all the required fields are completed.Further, added a section to check if
isAllFieldsFilledandisValidare true => have the login button / signup button as "blue"/primary color, else, by default it is grey.Issue #90