Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger CI on PR review_request #141

Merged
merged 1 commit into from
Aug 15, 2023
Merged

trigger CI on PR review_request #141

merged 1 commit into from
Aug 15, 2023

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Aug 15, 2023

Pull Request Description

CI appeared to be only running on the default branch on the schedule. This also adds a CI run on branches when review is requested on a PR.

Checklist

  • All ci tests pass (green)
  • This branch is up-to-date with develop

@vtnate vtnate added the ignore-for-release Exclude this PR from release notes label Aug 15, 2023
@vtnate vtnate self-assigned this Aug 15, 2023
@vtnate vtnate requested a review from kflemin August 15, 2023 15:32
@vtnate
Copy link
Collaborator Author

vtnate commented Aug 15, 2023

🙌 Woohoo the GHA didn't trigger until I requested a review. This appears to be working as expected.

@vtnate
Copy link
Collaborator Author

vtnate commented Aug 15, 2023

I expect we'll keep getting the unfinished Jenkins check until Tim removes UO from his Jenkins config. Until then we should ignore it. Unfortunately that means we need admin rights to bypass branch protections when merging PRs.

@vtnate vtnate merged commit 1f36b61 into develop Aug 15, 2023
1 check passed
@vtnate vtnate deleted the ci-tweaks branch August 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Exclude this PR from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants