Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use corepack to automatically handle pnpm version & use GitHub composite actions #568

Merged
merged 4 commits into from
May 25, 2024

Conversation

MuhammadM1998
Copy link
Contributor

@MuhammadM1998 MuhammadM1998 commented May 24, 2024

Currently the pnpm version is hardcoded in workflows file and needs to be updated manually like this 4fc463a (#531) otherwise CI fails.

This PR does the following

  • Enables corepack which automatically uses the specified version by packageManager in package.json.
  • Moves the shared setup (Installing node & enabling corepack) into a GitHub Composite Action which is basically a reusable workflow that saves us duplication of steps across the workflows.
  • Bumps actions/checkout to v4 for consistency as both v2 and v3 were used in different workflows.
  • Replaces npx with pnpm dlx in changelogithub script for consistency as we're using pnpm

@sadeghbarati sadeghbarati merged commit 6a6968b into unovue:dev May 25, 2024
1 check passed
@sadeghbarati
Copy link
Collaborator

@MuhammadM1998 🙌

@MuhammadM1998 MuhammadM1998 deleted the ci/enable-corepack branch May 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants