Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SDK v3.6+ and change to support non-english characters #17

Closed
wants to merge 2 commits into from
Closed

use SDK v3.6+ and change to support non-english characters #17

wants to merge 2 commits into from

Conversation

andrwj
Copy link
Contributor

@andrwj andrwj commented Nov 4, 2015

Some changes for compiling SDK v3.6 and displaying non-english characters.
The '/script.js' should be modified to accept encodeURIComponent(), decodeURIComponent() functions around 76, 219 lines:

line#76

$(document).ready(function() {
  var data = jQuery.parseJSON(decodeURIComponent(window.location.hash.substring(1)));

  if (data !== "") {
    renderData(data);
  }
});

line#219

function generatePebbleURL() {
  data = collectData(true);

  if (!data) {
    return;
  }

  data_str = encodeURIComponent(JSON.stringify(data));

  location.href = 'pebblejs://close#' + data_str;
}

@unlobito
Copy link
Owner

unlobito commented Nov 4, 2015

Hi Andrew,

I really appreciate your help with attempting to make special characters work but I'm unfortunately unable to accept this pull request as base64 was intentionally used to resolve issue #13. Base64 is another encoding format that serves a similar purpose as URI encoding and also allows special characters to be safely delivered to the server and back.

Special character support is a two-fold issue: skunk doesn't (to the best of my knowledge) use a font that supports displaying the right glyphs and skunk-config chokes on the special characters. I've opened issue #18 to keep track of this.

Please feel free to create another pull request with just https://github.com/andrwj/skunk/commit/e73e81014383d1d4f525b0ebd3802fdfc4137abc or a different solution to #18

Thank you very much for your help. :)

@unlobito unlobito closed this Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants