Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Telnet Linemode and SGA Option #127

Open
wants to merge 1 commit into
base: feat/telnet-other-options
Choose a base branch
from

Conversation

mystiker
Copy link
Collaborator

@mystiker mystiker commented Nov 4, 2024

Description

This change adds two new features to all Telnet option handlers: getPreviousNegotiation and isDynamic.

The getPreviousNegotiation function allows option handlers to access the previous negotiation result, enabling more flexible and dynamic negotiation of Telnet options between the client and server.

The isDynamic property indicates whether an option handler is dynamic or not. A dynamic option handler can change its negotiation even after the first negotiation during runtime, while a non-dynamic option handler always sticks to its first decision. When isDynamic is set to true, the option handler can change its negotiation based on the previous negotiation results.

Changes

  • The getPreviousNegotiation function was added to allow option handlers to access the previous negotiation result.
  • The isDynamic property was added to indicate whether an option handler is dynamic or not.
  • The handleLinemodeOption function was updated to support the new features.
  • Support for the Telnet option LINEMODE (34) was added, allowing negotiation line mode with the server.
  • Support for the Telnet option SGA (3) was added, allowing to suppress go-ahead messages from the server.

Fixes #114
Fixes #115

- present a DO for SGa
- answer with WILL for LINEMODE
- updated readme for telnet feature
- its now possible to access the previous value of a negotiation
- handler can now be marked as dynamic which does allow later modifications
@mystiker mystiker changed the base branch from develop to feat/telnet-other-options November 4, 2024 15:07
@mystiker mystiker self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Telnet SGA Option (Suppress Go Ahead) Implement Telnet LINEMODE Option
1 participant