Improve portability, explicitly use GNU/make on macOS #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spjmurray
reviewed
Jun 19, 2024
| @@ -8,4 +8,10 @@ | |||
| CHART="$(ls charts)" | |||
| CHART_META="charts/${CHART}/Chart.yaml" | |||
|
|
|||
| make images-kind-load VERSION="$(yq .version "${CHART_META}")" | |||
| if [[ "$(uname)" == "Darwin" ]]; then | |||
There was a problem hiding this comment.
I mean, given
[Wed 19 Jun 11:34:08 BST 2024] simon@symphony ~/src/github.com/unikorn-cloud/scripts which gmake
/usr/bin/gmake
I wouldn't be opposed to just changing the command rather than having a sprawling mess of control flow
There was a problem hiding this comment.
Well now that you mention it, what I actually want to do is to state that developers on macOS should use Colima, and then this build command becomes gmake build images.
There was a problem hiding this comment.
Well then, given kubeclt version doesn't give away the platform, and a special flag will be intrusive to someone, I'd consider switching the command based on a config file, say ~/.config/unikorn/scipts.yaml. That would look like...
platform: kindThen do
MAKE_TARGET=images
if [[ "$(yq .platform /.config/unikorn/scipts.yaml)" == "kind" ]]; then
MAKE_TARGET=images-kind-load
fi
gmake "${MAKE_TARGET}" ...blah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.