Add in Actions and CI (#3)

.github/workflows/pull-request.yaml

@@ -0,0 +1,16 @@
+name: Pull Request
+on:
+  pull_request:
+    types:
+    - opened
+    - synchronize
+    - reopened
+    - ready_for_review
+jobs:
+  Static:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Shellcheck
+      uses: ludeeus/action-shellcheck@master

README.md

@@ -53,3 +53,7 @@ Test a functional change:
 ```shell
 build && restart
 ```
+
+## Contribution
+
+Be aware you need to run `shellcheck` and pass before acceptance.

build

@@ -5,4 +5,7 @@
 #
 # NOTE: must be run from the compenent's root directory.
 
-make images-kind-load VERSION=$(cat charts/$(ls charts)/Chart.yaml | yq .version)
+CHART="$(ls charts)"
+CHART_META="charts/${CHART}/Chart.yaml"
+
+make images-kind-load VERSION="$(yq .version "${CHART_META}")"

clean-images

@@ -2,4 +2,5 @@
 
 # Removes any dangling docker images, or which there will be many.
 
-docker rmi $(docker images -f dangling=true | grep -e \^\< | awk '{ print $3; }')
+# shellcheck disable=SC2046
+docker rmi $(docker images -f dangling=true | grep -e ^\< | awk '{ print $3; }')

deploy

@@ -7,7 +7,7 @@
 # NOTE: must be run from the compenent's root directory.
 
 # Grab the repository.
-REPO=$(basename $(pwd))
+REPO=$(basename "$(pwd)")
 
 # Get the environemnt.
 # TODO: getopts
@@ -43,7 +43,7 @@ CRDDIR="${CHARTDIR}/crds"
 
 # Update CRDs if necessary, helm won't do this for you.
 if [[ -d ${CRDDIR} ]]; then
-	kubectl apply -f ${CRDDIR}
+	kubectl apply -f "${CRDDIR}"
 fi
 
 ARGS=()
@@ -52,8 +52,8 @@ ARGS=()
 VALUESFILE="${HOME}/.config/unikorn/${ENVIRONMENT}/${REPO}.yaml"
 
 if [[ -f ${VALUESFILE} ]]; then
-	ARGS+=("-f" ${VALUESFILE})
+	ARGS+=("-f" "${VALUESFILE}")
 fi
 
 # Deploy the actual chart.
-helm upgrade --install --create-namespace -n ${NAMESPACE} ${RELEASE} ${CHARTDIR} ${ARGS[@]}
+helm upgrade --install --create-namespace -n ${NAMESPACE} ${RELEASE} "${CHARTDIR}" "${ARGS[@]}"

restart

@@ -7,7 +7,7 @@
 # NOTE: must be run from the compenent's root directory.
 
 # Grab the repository.
-REPO=$(basename $(pwd))
+REPO=$(basename "$(pwd)")
 
 # Do any specializations.
 case ${REPO} in

ui-preview

@@ -16,7 +16,8 @@ if [[ ! -f ${ENVFILE} ]]; then
 fi
 
 set -a
-source ${ENVFILE}
+# shellcheck disable=SC1090
+source "${ENVFILE}"
 set +a
 
 npm run dev