Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add shadcn/ui examples #34

Closed
wants to merge 3 commits into from

Conversation

Xy2002
Copy link
Contributor

@Xy2002 Xy2002 commented Nov 13, 2024

Added examples for manual installation and CLI using shadcn/ui in TNF


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC. Roadmap #2
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests and other checks with pnpm ci

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features and fix bugs should all be patch before we release 0.1.0. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 4595f48

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、一个 pr 只做一件事,不要既增加 example 又修改功能,不好合
2、example 不需要加 changeset
3、generate 部分需要 revert,我在 master 做了重构,全冲突了

@Xy2002
Copy link
Contributor Author

Xy2002 commented Nov 13, 2024

1、一个 pr 只做一件事,不要既增加 example 又修改功能,不好合 2、example 不需要加 changeset 3、generate 部分需要 revert,我在 master 做了重构,全冲突了

好的,我重新提交pr

@Xy2002 Xy2002 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants