-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip chore: targets default from chrome 80 to any-target #1451
base: master
Are you sure you want to change the base?
Conversation
Walkthrough此次更改主要涉及 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- crates/mako/src/config/config.rs (1 hunks)
- packages/bundler-mako/index.js (1 hunks)
Additional comments not posted (2)
packages/bundler-mako/index.js (1)
603-603
: 更改默认目标配置。将
targets
属性的默认值从特定的 Chrome 版本更改为空对象{}
,这将增强与更多环境的兼容性。crates/mako/src/config/config.rs (1)
686-686
: 更改默认目标配置。将
DEFAULT_CONFIG
常量中的targets
字段从特定的 Chrome 版本更改为空对象{}
,这将增强与更多环境的兼容性。
@@ -683,7 +683,7 @@ const DEFAULT_CONFIG: &str = r#" | |||
"providers": {}, | |||
"publicPath": "/", | |||
"inlineLimit": 10000, | |||
"targets": { "chrome": 80 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是个 break change。
use swc preset-env any_targets to align umi default targets(babel-preset-env options
{ targets: {} })
Summary by CodeRabbit
新功能
变更
targets
属性的默认值,简化了配置设置。