Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for dot notation #960

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fixes for dot notation #960

merged 2 commits into from
Jul 27, 2023

Conversation

ukrbublik
Copy link
Owner

@ukrbublik ukrbublik commented Jul 27, 2023

  • Fixed import of fields with dot from JsonLogic
  • Fixes export to SpEL to respect fieldSeparator

Resolves #786, #958

@codesandbox
Copy link

codesandbox bot commented Jul 27, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 11:32am
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 11:32am
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Jul 27, 2023 11:32am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2197418:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #960 (2197418) into master (40321b2) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   81.62%   81.69%   +0.07%     
==========================================
  Files         182      182              
  Lines        9898     9894       -4     
  Branches     1207     1207              
==========================================
+ Hits         8079     8083       +4     
+ Misses       1231     1223       -8     
  Partials      588      588              
Files Changed Coverage Δ
packages/core/modules/config/index.js 75.00% <100.00%> (+0.27%) ⬆️
packages/core/modules/export/mongoDb.js 89.18% <100.00%> (+0.04%) ⬆️
packages/core/modules/export/spel.js 86.60% <100.00%> (+0.08%) ⬆️
packages/core/modules/import/jsonLogic.js 92.64% <100.00%> (+1.56%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant