Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cardinality issue #1136

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix cardinality issue #1136

merged 1 commit into from
Nov 12, 2024

Conversation

rhit-gaulldj
Copy link
Contributor

- Addresses ukrbublik#1118
- Re-reads values from previous state if new cardinality is less than current cardinality
Copy link

codesandbox bot commented Nov 12, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 4:30pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 4:30pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 4:30pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c23eac:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (e691234) to head (4c23eac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         212      212           
  Lines       11184    11184           
  Branches     1343     1343           
=======================================
  Hits         9180     9180           
  Misses       1378     1378           
  Partials      626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ukrbublik ukrbublik merged commit 25efcb2 into ukrbublik:master Nov 12, 2024
13 checks passed
@ukrbublik
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching From Operator with Cardinality 2 to Operator with Cardinality 1 Does Not Properly Change Tree
2 participants