Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: parallel version of multi_localminmax.hxx #203

Open
wants to merge 21 commits into
base: parallelization
Choose a base branch
from
Open

WIP: parallel version of multi_localminmax.hxx #203

wants to merge 21 commits into from

Conversation

minhb
Copy link

@minhb minhb commented Aug 14, 2014

Hi,

I updated the parallel version of the node iteration section in the following functions:

  • boost_graph::localMinMaxGraph
  • lemon_graph::localMinMaxGraph
  • lemon_graph::extendedLocalMinMaxGraph

The test file is test/openmp/test_omp_multi_localminmax.cxx

There are two issues I have:

  1. I could not find the test for function: lemon_graph::extendedLocalMinMaxGraph. So, I tested only two left functions.
  2. In the parallel region, I want to get rid of break statement. I think, in the parallel region when one thread hits break statement, the others should stop executing their loop iterations. This could save us some useless work.

Although, I would like to make this pull request to discuss about the parallel version of above functions.

Remark: I would like to make a separate pull request for this issue. Unfortunately, the previous commits still stayed in this pull request. So, please consider changes in only two files: test/openmp/test_omp_multi_localminmax.cxx and include/vigra/multi_localminmax.hxx .

Best regards,
Minh

@minhb minhb changed the title Openmp multi localminmax Updated parallel version of the node iteration section@multi_localminmax.hxx Aug 14, 2014
@minhb minhb changed the title Updated parallel version of the node iteration section@multi_localminmax.hxx Updated parallel version of the node iteration sections@multi_localminmax.hxx Aug 14, 2014
@ukoethe
Copy link
Owner

ukoethe commented Mar 6, 2016

This PR cannot be used as is because we abandoned OpenMP in favor of std::thread. But it still contains lots of useful code, so I keep it open for now.

@ukoethe ukoethe changed the title Updated parallel version of the node iteration sections@multi_localminmax.hxx WIP: parallel version of multi_localminmax.hxx Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants