generated from netreconlab/CareKitSample-ParseCareKit
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
github-classroom
wants to merge
8
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added appearance style * Started login screen design, connected to server * Changed some coloring * Completed rework of login page, created stylers for appearance and dimension, reworked task tile colors.
* In class revisions. Unfinished and needs to be completed * Updates all files giving me errors. Back in stable state where building is possible.
* Added 'add task' button * Completed 'add task' button. Still need to populate cards on mainView * Started to try to add scheduling input on a task. May need more work as it is blowing up the logger and task is still not displayed after Add * Fixed small changes from PR * Tasks now populate on careView, scheduling issue fixed * Final commit for HW4. Added ability to choose between health tasks
* Starting PR changes in class - needs to be finished * Finished PR. REVERT HERE IF NECESSARY. Need to fix add task functionality * Completed the profile tasks and myContactToDo * Final commit for HW5.
* Started PR changes but having errors in careViewController with extra/not enough brackets * Almost Done with PR. Stopped on checkIn.swift * Started on TODO's * More TODO work completed. Need to finish onboarding stuff and one more * Completed TODO's. Now working on adding some custom functionality and cleaning up before PR
* Started PR changes but having errors in careViewController with extra/not enough brackets * Almost Done with PR. Stopped on checkIn.swift * Started on TODO's * More TODO work completed. Need to finish onboarding stuff and one more * Completed TODO's. Now working on adding some custom functionality and cleaning up before PR * Fixed for_where error
* Started PR. Stopped halfway through CareViewController need to finish * Finished PR. Getting threading error even though I haven't changed anything * Working on sample healthKit tasks * Finished adding a custom note card. Need to go over all TODO's and go through canvas requirements still * Finished most of canvas requirements. Need to work on TODO's now * Finished some scheduling and fixed healthKitTasks * Finished all TODO's & code cleanup. Need to prepare for demo * Updating README * Fixed sample task * task fixes * Added demo video to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
main
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @brandon-wever