-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Update forecast metric test script #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! However, I did note that the old regional_workflow
conda environment is still being loaded. In PR #793, the conda environment was changed to workflow_tools
. It would be a good idea to change line 49 so that it reads:
conda activate workflow_tools
The test was run with both regional_workflow
and workflow_tools
. Both tests successfully passed. Will approve after regional_workflow
has been updated to workflow_tools
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @clouden90! Approving now.
The Cheyenne Intel WE2E coverage tests were manually run on Hera and all successfully passed:
The Cheyenne GNU WE2E coverage tests were manually run on Hera and all successfully passed:
Unfortunately, the |
The Jet tests were manually run and have successfully completed:
Now moving forward with merging this work. |
DESCRIPTION OF CHANGES:
Update
srw_metric_example.sh
to remove the explicit setting ofMET_INSTALL_DIR
andMET_BIN_EXEC
environment variables. (This change comes after #826, where these variables are sourced directly from the modulefiles.)TESTS CONDUCTED:
To start, git clone the feature branch, then navigate to the ufs-srweather-app folder and proceed to check out the external repositories. Set the following environment variables: WORKSPACE (path to your
ufs-srweather-app
folder), SRW_PLATFORM (e.g.,hera
), SRW_COMPILER (e.g.,intel
), and SRW_PROJECT (e.g.,nems
). Once these are set, run the command./.cicd/scripts/srw_metric_example.sh
. This process is expected to take around 2 hours to complete. Afterward, you should find an output file named skill-score.out that contains the skill score index. Tests have been conducted on Hera and Jenkins pipeline.CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):