-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Adding in the tutorial for the Halloween Storm #1124
Conversation
PR ufs-community#1124/ Halloween Storm updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noted two minor spelling/grammatical issues in my review. Also, I noticed the comment regarding QUILTING. QUILTING is required for regional grids and is set to true by default in config_defaults.yaml
. Additionally, the config.community.yaml
file already has QUILTING: true
set for task_run_fcst:
, so you should be fine with not modifying the task_run_fcst:
section for the tutorial.
Co-authored-by: Michael Lueken <[email protected]>
Co-authored-by: Michael Lueken <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making my recommended changes, @jdkublnick! Approving now.
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
DESCRIPTION OF CHANGES:
This PR adds a tutorial to the Tutorials chapter of the SRW App User's Guide. It is based off the Halloween Storm UFS case study.
Type of change
TESTS CONDUCTED:
None required.
DEPENDENCIES:
None
DOCUMENTATION:
Build on RTD: https://ufs-srweather-app-joshua-kublnick.readthedocs.io/en/text-us-216/UsersGuide/index.html
ISSUE:
Addresses issue #1123
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):