-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debian/control: Bump dependency on go 1.23 and use explicit package name #584
Conversation
That's what we actually require
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 83.55% 83.51% -0.05%
==========================================
Files 80 80
Lines 7019 7013 -6
Branches 75 75
==========================================
- Hits 5865 5857 -8
- Misses 823 824 +1
- Partials 331 332 +1 ☔ View full report in Codecov by Sentry. |
It’s something we need to discuss during the meeting. I didn’t do it on purpose because "main" is supposed to be latest dev version. However, we can talk about it as we know we’ll be in the ppa for quite some time and targeting 24.04 first… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said during the meeting, I think we should go with something around this. That will help as we are backporting this for a quite a while in the ppa. However, we can probably make it more forward-compatible to avoid reexporting variables.
Also, it would be a good way to have a single debian/rules and debian/control for current released versions and all backports!
So that authd can be easily compiled on other versions such as 22.04, and in case that we forget to update this value when bumping our go.mod toolchain, then we'll fail at debian build phase (as expected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it! That way, no more packaging divergence to get our project building on older releases. This is something I will definitively steal and backport to other projects. Well done! :)
We forget to update this.
Also in this way authd can be easily compiled on other versions such as 22.04,
and in case that we forget to update this value when bumping our go.mod
toolchain, then we'll fail at debian build phase (as expected)
Helps: #534