Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/control: Bump dependency on go 1.23 and use explicit package name #584

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Oct 14, 2024

We forget to update this.

Also in this way authd can be easily compiled on other versions such as 22.04,
and in case that we forget to update this value when bumping our go.mod
toolchain, then we'll fail at debian build phase (as expected)

Helps: #534

That's what we actually require
@3v1n0 3v1n0 requested a review from a team as a code owner October 14, 2024 10:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (ab89e4f) to head (37e7f77).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   83.55%   83.51%   -0.05%     
==========================================
  Files          80       80              
  Lines        7019     7013       -6     
  Branches       75       75              
==========================================
- Hits         5865     5857       -8     
- Misses        823      824       +1     
- Partials      331      332       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks
Copy link
Member

It’s something we need to discuss during the meeting. I didn’t do it on purpose because "main" is supposed to be latest dev version. However, we can talk about it as we know we’ll be in the ppa for quite some time and targeting 24.04 first…

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said during the meeting, I think we should go with something around this. That will help as we are backporting this for a quite a while in the ppa. However, we can probably make it more forward-compatible to avoid reexporting variables.

Also, it would be a good way to have a single debian/rules and debian/control for current released versions and all backports!

debian/control Outdated Show resolved Hide resolved
debian/rules Outdated Show resolved Hide resolved
debian/rules Outdated Show resolved Hide resolved
So that authd can be easily compiled on other versions such as 22.04,
and in case that we forget to update this value when bumping our go.mod
toolchain, then we'll fail at debian build phase (as expected)
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it! That way, no more packaging divergence to get our project building on older releases. This is something I will definitively steal and backport to other projects. Well done! :)

@3v1n0 3v1n0 merged commit 921a6eb into ubuntu:main Oct 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants