Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing typescript support #2919

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sanathusk
Copy link

The PR includes that allow typescript support in svelte components.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 83.61% // Head: 83.84% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (09be8e5) compared to base (919a81e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2919      +/-   ##
==========================================
+ Coverage   83.61%   83.84%   +0.23%     
==========================================
  Files          31       32       +1     
  Lines        1050     1065      +15     
==========================================
+ Hits          878      893      +15     
  Misses        172      172              
Impacted Files Coverage Δ
src/lib/window.js 100.00% <0.00%> (ø)
src/lib/reporter.js 100.00% <0.00%> (ø)
src/core/plugins/index.js 100.00% <0.00%> (ø)
src/core/helpers/session.js 100.00% <0.00%> (ø)
src/core/core.js 72.14% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tsconfig.json Outdated Show resolved Hide resolved
Copy link
Member

@NeoTheThird NeoTheThird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at @maciek134's requests, then it looks good!

@sanathusk sanathusk requested review from maciek134 and NeoTheThird and removed request for maciek134 November 29, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants