-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests of invalid REST parameters. #95
Open
aaronweeden
wants to merge
6
commits into
ubccr:main
Choose a base branch
from
aaronweeden:fix-rest-array-param-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add integration tests of invalid REST parameters. #95
aaronweeden
wants to merge
6
commits into
ubccr:main
from
aaronweeden:fix-rest-array-param-validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
from
October 6, 2023 16:46
86f3a49
to
8eaf152
Compare
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
6 times, most recently
from
December 8, 2023 22:36
d615af9
to
67826dc
Compare
Merged
3 tasks
aaronweeden
requested review from
eiffel777,
jpwhite4,
ryanrath,
connersaeli and
aestoltm
December 11, 2023 20:02
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
3 times, most recently
from
January 16, 2024 19:13
c86a526
to
cabbfe0
Compare
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
from
February 20, 2024 16:04
cabbfe0
to
cde368d
Compare
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
2 times, most recently
from
May 6, 2024 12:58
59d8f14
to
a922b41
Compare
aaronweeden
force-pushed
the
fix-rest-array-param-validation
branch
from
May 28, 2024 15:41
a922b41
to
7762e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests that test the validation of REST parameters that are obtained via the
getParam()
method ofBaseControllerProvider
.This PR is based on #98. The diff between the PRs can be viewed here.
Tests performed
To run the tests, I did the following in a Docker container running
tools-ext-01.ccr.xdmod.org/xdmod-10.5.0-x86_64:rockylinux8.5-0.3
:Types of changes
Checklist: