Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @tus/azure-store #645

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Add @tus/azure-store #645

merged 12 commits into from
Sep 5, 2024

Conversation

battajegroup
Copy link
Contributor

I have added the basic support for Azure storage account upload. This is the basic implementation as the node sdk for Azure storage has some limitation for stream upload. Please have a look and let me know for any comments and suggestions. Thank you.

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: b92d1bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tus/azure-store Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Aug 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@azure/[email protected] filesystem Transitive: environment, network +19 12.4 MB microsoft1es
npm/@tus/[email protected] None 0 0 B

🚮 Removed packages: npm/@tus/[email protected]), npm/@tus/[email protected]), npm/@tus/[email protected]), npm/@tus/[email protected]), npm/@tus/[email protected])

View full report↗︎

@Murderlon
Copy link
Member

Sorry for the delay. I will take a look at it this week.

* main:
  [ci] release (tus#644)
  @tus/server: add allowedCredentials and allowedOrigins options (tus#636)
  Bump micromatch from 4.0.5 to 4.0.8 (tus#653)
  @tus/server: make test less flaky
  Correctly ignore dist/ in biome.json
  Replace Prettier and Eslint with Biome (tus#647)
  Revert "Bump rimraf from 3.0.2 to 6.0.1 (tus#649)"
  Bump sinon from 17.0.1 to 18.0.0 (tus#648)
  Bump rimraf from 3.0.2 to 6.0.1 (tus#649)
  Change name of CI workflow
  Remove turbo (tus#646)
@Murderlon Murderlon changed the title Basic support for Azure storage account upload Add @tus/azure-store Sep 5, 2024
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a handful of commits with tiny tweaks. The tests fail in CI because this PR gets the repository secrets at the time of opening the PR and I added them later. But I can confirm locally that all tests pass.

Initial version will be 0.1.0 instead of 1.0.0 when published. When it has proven itself stable we can do a major.

@Murderlon Murderlon merged commit 919cd85 into tus:main Sep 5, 2024
2 of 3 checks passed
@Murderlon Murderlon mentioned this pull request Sep 5, 2024
@battajegroup
Copy link
Contributor Author

You're welcome. Thank you for the review and accepting the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants