@tus/s3-store: Fix incorrect part retreival procedure #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjap
commented
Oct 26, 2023
Comment on lines
+482
to
483
| const partNumber: number = parts.length > 0 ? parts[parts.length - 1].PartNumber! : 0 | ||
| const nextPartNumber = partNumber + 1 |
There was a problem hiding this comment.
nextPartNumber should be calculated from last part number
mitjap
commented
Oct 26, 2023
| parts | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| .sort((a, b) => a.PartNumber! - b.PartNumber!) | ||
| .filter((value, index) => value.PartNumber === index + 1) |
There was a problem hiding this comment.
Maybe this filter was kind of fail-safe if some part in the middle was not uploaded. This does not prevent later file corruption if some part was uploaded only partially.
|
@Murderlon Would be possible to publish this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with
retrievePartsfunction.First issue is how it determines when to fetch more parts. Before it was using
data.NextPartNumberMarker && Number(data.NextPartNumberMarker) > 0to check if there are more parts to be fetch. This code made an assumption that final "page" will return "0" asNextPartNumberMarkerbut this is not specified in documentation and differs between S3 providers. Scaleway's S3 for example always return last part's number. Specification is clear on this that we should useIsTruncatedpropery.Next issue is with sorting the parts. When completing multipart upload parts must be ordered in ascending order. In existing code sorting was done only when there less then 1000 parts (no additional "pages").
Another issue is with filtering. I'm not sure why would we ever need to remove parts from this list.