@tus/s3-store: Don't download incomplete part on HEAD request #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murderlon
approved these changes
Oct 19, 2023
| return data.ContentLength | ||
| } catch (error) { | ||
| if (error instanceof NotFound) { | ||
| return undefined |
There was a problem hiding this comment.
nit: when there is no incomplete part we can also consider the size 0. Especially if we want to always do addition on the return value.
Suggested change
| return undefined | |
| return 0 |
There was a problem hiding this comment.
I was thinking about that. In this case we would not be able to tell if there is no incomplete part or if its size is 0. For HEAD request that distinguishing is actually not needed. I'm good with both ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on every HEAD request entire incomplete part is downloaded to memory.
This PR makes HEAD request to S3 to determine incomplete part size.