Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laser_scanner: fix off-by-one in angle_increment calculation #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gavanderhoorn
Copy link
Member

@gavanderhoorn gavanderhoorn commented Jan 28, 2024

This may fix the issues experienced by @ashchennikov in #57.

Some quick tests (fov: 5 degrees and fov: 90 degrees) show this to work:

image

(scans of the little pickets in front of the isles of the gas station with FOV: 90 degrees ([-45; 45]). Note: perspective is not identical, the laser scanner is mounted in front of the vehicle)

If you're still interested @ashchennikov, please give this a test.

I'll merge this next week, unless I find something is still wrong and/or someone reports an(other) issue with it.

Technically this could just be 'LS_FOV' now, but let's refactor some other time.
@ashchennikov
Copy link

ashchennikov commented Jan 29, 2024

@gavanderhoorn I may be doing something wrong, but don't really see any difference on my setup, the scan is still either whole 360° around the vehicle or rotated if I change the max and min angles. How have you configured the scan in mod_config.lua?
Update: here is what I see, the wall is on the right, in rviz I see it in front of me.
lidar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants