-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export bech32 and bech32m functions #4101
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR! Just one minor change please
84f463d
to
d134eff
Compare
Hi @satoshiotomakan, could you help review it? Also, could you trigger CI to run the tests? I can't run the iOS, Android, or TypeScript tests due to my local environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes! LGTM
Description
Export bech32 and bech32m functions. Fix issue #4100
How to test
Run Rust, C++, iOS, Android tests
Types of changes
Checklist
If you're adding a new blockchain