Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export bech32 and bech32m functions #4101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Nov 7, 2024

Description

Export bech32 and bech32m functions. Fix issue #4100

How to test

Run Rust, C++, iOS, Android tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@10gic 10gic changed the title Export bech32 and bech32m functions [WIP] Export bech32 and bech32m functions Nov 7, 2024
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR! Just one minor change please

include/TrustWalletCore/TWBech32.h Outdated Show resolved Hide resolved
include/TrustWalletCore/TWBech32m.h Outdated Show resolved Hide resolved
@10gic
Copy link
Contributor Author

10gic commented Nov 8, 2024

Hi @satoshiotomakan, could you help review it? Also, could you trigger CI to run the tests? I can't run the iOS, Android, or TypeScript tests due to my local environment.

@10gic 10gic changed the title [WIP] Export bech32 and bech32m functions Export bech32 and bech32m functions Nov 8, 2024
satoshiotomakan
satoshiotomakan previously approved these changes Nov 8, 2024
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants