Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files_renamed documentation #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

808sAndBR
Copy link

Type of Change

  • Documentation

Resolves

Describe Changes

This will add clarity about the availability of files_renamed which I believe is causing the confusion people have voiced in #108 where it is not actually a bug, but just that it is not clear that this data is available. As far as I can tell (I don't actually know js/ts) the renamed files are getting added/processed here:

files.forEach(f => {
changedFiles[f.status].push(
f.filename || f.added || f.removed || f.renamed || f.modified
)
changedFiles.files.push(
f.filename || f.added || f.removed || f.modified || f.renamed
)
and when I test trying to access the files_renamed object in my code that leverages this action it works as expected.

@remisalmon
Copy link

Thanks for opening this PR, outputs.files_renamed works as expected for me. Would be great to see this merged.

@808sAndBR
Copy link
Author

Hi @trilom just noticed this still open and wanted to check if there is anything useful I can do on my end. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renamed files do not show as modified, added or removed, but do appear in files
2 participants