Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grdddj/tests and typing #226

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Grdddj/tests and typing #226

merged 6 commits into from
Oct 25, 2023

Conversation

grdddj
Copy link
Contributor

@grdddj grdddj commented Oct 24, 2023

Couple small improvements (also see commit messages):

  • fix some broken tests
  • add test for TR
  • add some type hints
  • fix mypy test
  • replace removed trezorlib debug functionality with a different approach

@vdovhanych
Copy link
Member

But take a look at some of the tests. It failed.

@grdddj
Copy link
Contributor Author

grdddj commented Oct 25, 2023

But take a look at some of the tests. It failed.

Right, it looks like we cannot unzip the downloaded master emulators in the GA filesystem - https://github.com/trezor/trezor-user-env/actions/runs/6627572607/job/18002872098?pr=226#step:4:8637

I will try to set up the tests in CI against the latest production version, e.g. 2.6.1 currently - which should be there

It would be nice to have also a direct link to all the master emulators, instead of needing to unzip the archive (which also contains a lot of useless things)

@grdddj
Copy link
Contributor Author

grdddj commented Oct 25, 2023

Still some issues with running bridge - https://github.com/trezor/trezor-user-env/actions/runs/6638165351/job/18034060215?pr=226

I have removed the controller tests from CI and leave them local-only ... I am not sure it ever worked on Github Actions - previously, we had it on Gitlab and it was fine there

@grdddj grdddj merged commit b0ded2a into master Oct 25, 2023
1 check passed
@grdddj grdddj deleted the grdddj/tests_and_typing branch October 25, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants