-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove docker form nix-shell #188
Conversation
I am not sure this is possible, as then users would need to have We can theoretically assume they have |
Side-note - it seems like the tests are failing in I created an issue for that - #189, will create a |
That's something I thought. It should be looked on as a dependency of the system and not use nix-shell for that as we run it inside our docker container, docker in there is pointless for us, and it just takes up space. Yep, the test failed due to the inability to download the emulator. |
I am not against it, as long as the users will be fine :) |
ad45513
to
efc9654
Compare
That is very nice! What is strange is that the
|
That's mainly because we have fewer firmwares to download for the arm version as the old ones do not work there. We should also consider doing this - #144 |
Good point. I see that my
If we know exactly which versions are no longer used, let's delete them. Hard to say whether to delete them on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this 👍.
Ok, merging this, docs are OK as it's stated there you need docker for this to work. We can do the firmware deletion later. |
As there is no need for docker to be present in nix-shell, I would remove it and save us some space in the docker image.
closes #175