Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockchain-link): Solana getAccountInfo - optimize for basic details #15445

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(blockchain-link): Solana getAccountInfo - optimize for basic details #15445

wants to merge 1 commit into from
+36 −29

Conversation

martykan
Copy link
Member

@martykan martykan commented Nov 19, 2024 •
edited
Loading

Description

Reduce the amount of calls for Solana getAccountInfo with basic details

  • Don't call getAccountInfo, getMinimumBalanceForRentExemption. This removes misc.owner, misc.rent fields which are rarely used.
  • Don't fetch all transaction ids, just the first page. The account freshness is then checked by the latest transaction signature.

Future Ideas:

  • When subsequently loading the full account with transactions, reuse data from previous request

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 11
  • More info

Learn more about 𝝠 Expo Github Action

@martykan martykan force-pushed the chore/solana-getaccountinfo-optimization branch from f31a3ec to 6681897 Compare November 19, 2024 12:17
@martykan martykan force-pushed the chore/solana-getaccountinfo-optimization branch from 577e1b7 to e9b9c72 Compare November 19, 2024 15:40
@martykan martykan marked this pull request as ready for review November 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@tomasklim tomasklim Awaiting requested review from tomasklim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martykan