Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable solana unsubscriptions #15439

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

enjojoy
Copy link
Contributor

@enjojoy enjojoy commented Nov 19, 2024

Description

Disabled solana accounts unsibscriptions on disconnect

Related Issue

Resolve #12628

Screenshots:

It does throw some errors but the app closes instantly.
image

@enjojoy
Copy link
Contributor Author

enjojoy commented Nov 19, 2024

@marekrjpolak Does this make sense to you as a temporary solution? The app does close instantly now

@enjojoy
Copy link
Contributor Author

enjojoy commented Nov 19, 2024

Also checked it out with @martykan , it should be ok. Shall we include it into this release? @tomasklim

@enjojoy enjojoy marked this pull request as ready for review November 19, 2024 09:07
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not 💯 clean, but I believe it shouldn't cause any serious trouble while it fixes some, so 🦭✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't close Trezor Suite with Tor On and Solana account active
2 participants