fix node-bridge segfault #15338
Open
fix node-bridge segfault #15338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
transport-fixes-segfault
branch
2 times, most recently
from
460d358
to
6647c41
Compare
mroz22
commented
Nov 14, 2024
| @@ -354,21 +354,34 @@ export class UsbApi extends AbstractApi { | |||
| } | |||
|
|
|||
| public async closeDevice(path: string) { | |||
| const device = this.findDevice(path); | |||
| let device = await this.findDevice(path, true); | |||
There was a problem hiding this comment.
this is the important change that makes it work on my machine. adding true here. Other places could maybe force enumeration too but I wanted to make changes minimal.
trezor-ci
force-pushed
the
transport-fixes-segfault
branch
from
6647c41
to
1c8ce36
Compare
mroz22
force-pushed
the
transport-fixes-segfault
branch
from
1c8ce36
to
d4e6fff
Compare
…on request displayed on device
mroz22
force-pushed
the
transport-fixes-segfault
branch
from
d4e6fff
to
2422801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit - just refactoring I felt makes sense
2nd commit - fixes #15336, it works on my machine but is not nice.