T3W1 PCB bring-up #4350
Open
T3W1 PCB bring-up #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TychoVrahe
force-pushed
the
tychovrahe/T3W1/led
branch
3 times, most recently
from
6c5b0e5
to
58a77d7
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3W1/led
branch
from
019f66d
to
8c143a2
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3W1/led
branch
from
8c143a2
to
1dcc256
Compare
cepetr
force-pushed
the
cepetr/drv-relocation
branch
3 times, most recently
from
f4bba1f
to
9e700bf
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3W1/led
branch
from
1dcc256
to
35f7a9e
Compare
cepetr
force-pushed
the
cepetr/drv-relocation
branch
from
9e700bf
to
5d9e2c6
Compare
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
…roperly [no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/T3W1/led
branch
from
35f7a9e
to
6aad200
Compare
prusnak
reviewed
Nov 18, 2024
| @@ -369,7 +369,7 @@ int bootloader_main(void) { | |||
| #ifdef USE_TOUCH | |||
| secbool touch_initialized = secfalse; | |||
| secbool allow_touchless_mode = secfalse; | |||
| #ifdef TREZOR_MODEL_T3T1 | |||
| #if defined TREZOR_MODEL_T3T1 || defined TREZOR_MODEL_T3W1 | |||
| // on T3T1, tester needs to run without touch, so making an exception | |||
There was a problem hiding this comment.
maybe add T3W1 to the comment too?
[no changelog]
cepetr
requested changes
Nov 19, 2024
| @@ -41,8 +41,7 @@ uint8_t physical_frame_buffer_1[PHYSICAL_FRAME_BUFFER_SIZE]; | |||
|
|
|||
| // The current frame buffer selector at fixed memory address | |||
| // It's shared between bootloaders and the firmware | |||
| __attribute__((section(".framebuffer_select"))) uint32_t current_frame_buffer = | |||
| 0; | |||
| uint32_t current_frame_buffer = 0; | |||
There was a problem hiding this comment.
Since the current_frame_buffer is no longer persistent, we can move it to the driver state structure.
| drv->active_fb_addr = (uint32_t)addr; | ||
| drv->active_fb_size = size; | ||
|
|
||
| mpu_reconfig(drv->mode); |
There was a problem hiding this comment.
I would be better to add some synchronization here since drv->active_fb_xxx can be now potentially used in the interrupt context.
irq_key_t irq_key = irq_lock();
drv->active_fb_addr = ..;
drv->active_fb_size = ..;
irq_unlock(irq_key);
mpu_reconfig(drv->mode);| @@ -208,12 +210,15 @@ static void copy_fb_to_display(uint8_t index) { | |||
| uint16_t *fb = (uint16_t *)get_fb_ptr(index); | |||
|
|
|||
| if (fb != NULL) { | |||
| mpu_set_active_fb(fb, PHYSICAL_FRAME_BUFFER_SIZE); | |||
There was a problem hiding this comment.
By adding this, the copy_fb_to_display function now has the side effect of disabling the frame buffer (for both privileged and unprivileged modes). This slightly impacts the display API behavior - after calling display_set_orientation, the acquired frame buffer is no longer accessible. I believe we don’t need to fix this, but it’s important to be aware of it.
There was a problem hiding this comment.
as discussed in person, lets postpone fixing this until needed
TychoVrahe
requested review from
prusnak and
cepetr
and removed request for
prusnak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RGB LED driver for T3W1. Syscall is added to enable driving from app.
Old RGB LED driver is removed, as it is no longer needed after ditching old boards.
Power button configuration is added to rev A board.
There was an error in setting the U5 clock with 32MHz HSE, so i fixed it here too. Some unused clock-configuration stuff is removed from startup_init.
Another HSE implications are for systick calculation, which need proper value set in stm32u5xx_hal_conf.h, so i replaced the HSE_xxMHz with native HSE_VALUE=xxx and move it to global.
USB driver was adjusted to work with 32MHz HSE too.
SBU pins are configured for T3W1. I removed "sbu" from features wanted in firmware, kernel and unix, its only needed for prodtest.
Another MPU bugfix: kernel SRAM setting was off, as SRAM1 now contains framebuffe on U5G.
The mock display driver was modified a bit so it doesn't crash when someone tries some rendering - one framebuffer is allocated for that purpose.