Fix mismatch of OpenSSL function signatures that cause errors with gc… #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 7, 2024
https://build.opensuse.org/request/show/1172350 by user mgerstner + dimstar_suse - Add gcc14-fixes.patch: Building with gcc14 fails due to a mismatch in OpenSSL function declarations. Provided PR# to upstream here: tpm2-software/tpm2-tss-engine#283 - Add tpm2-tss-engine.keyring: needed for validation of the tarball signature. This keyring is taken over from tpm2-0-tss which has the same (or very similar) maintainers.
|
@williamcroberts any chance you could please look into this PR? The project fails to build with GCC 14 |
williamcroberts
approved these changes
Aug 11, 2024
|
@mgerstner can you sign off on your commit and re-push? Otherwise, LGTM. |
…c-14
Building with gcc-14 fails with diagnostics like this:
```
src/tpm2-tss-engine-rsa.c:805:46: error: passing argument 2 of 'EVP_PKEY_meth_set_copy' from incompatible pointer type [-Wincompatible-pointer-types]
805 | EVP_PKEY_meth_set_copy(pkey_rsa_methods, rsa_pkey_copy);
| ^~~~~~~~~~~~~
| |
| int (*)(EVP_PKEY_CTX *, EVP_PKEY_CTX *) {aka int (*)(struct evp_pkey_ctx_st *, struct evp_pkey_ctx_st *)}
/usr/include/openssl/evp.h:2005:36: note: expected 'int (*)(EVP_PKEY_CTX *, const EVP_PKEY_CTX *)' {aka 'int (*)(struct evp_pkey_ctx_st *, const struct evp_pkey_ctx_st *)'} but argument is of type 'int (*)(EVP_PKEY_CTX *, EVP_PKEY_CTX *)' {aka 'int (*)(struct evp_pkey_ctx_st *, struct evp_pkey_ctx_st *)'}
```
A look into OpenSSL upstream shows that these functions have always had const
`src` parameters. Thus this error was simply not detected by earlier compiler
versions.
Signed-off-by: Matthias Gerstner <[email protected]>
I just did so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c-14
Building with gcc-14 fails with diagnostics like this:
A look into OpenSSL upstream shows that these functions have always had const
srcparameters. Thus this error was simply not detected by earlier compiler versions.