Removed redundant cache updates in the DataCache class.

torikushiii · Aug 23, 2024 · 3861f66 · 3861f66
1 parent 760a41b
commit 3861f66
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/hoyolab-modules/cache.js b/hoyolab-modules/cache.js
@@ -49,12 +49,7 @@ module.exports = class DataCache {
 			if (cachedData) {
 				app.Logger.debug("Cache", `Cache hit for key: ${key} (memory)`);
 
-				const updatedData = await this.#updateCachedData(cachedData);
-
-				DataCache.data.set(key, updatedData);
-				await app.Cache.set({ key, value: updatedData, expiry: this.expiration });
-
-				return updatedData;
+				return await this.#updateCachedData(cachedData);
 			}
 
 			// 2. Attempt to get data from keyv cache
@@ -64,9 +59,7 @@ module.exports = class DataCache {
 					app.Logger.debug("Cache", `Cache hit for key: ${key} (keyv)`);
 
 					const updatedData = await this.#updateCachedData(cachedData);
-
 					DataCache.data.set(key, updatedData);
-					await app.Cache.set({ key, value: updatedData, expiry: this.expiration });
 
 					return updatedData;
 				}