Update TVM Whitepaper: Correct Serialization Instruction for F4A6_ #1336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team,
I've noticed a discrepancy in the TVM whitepaper regarding the serialization instruction for the opcode F4A6_. The current text states that "the instruction can be obtained by first serializing F4A8," which appears to be an error.
Upon reviewing the binary representation, F4A6 in binary is
11110100101001
. It's not possible to append bits to this sequence to form F4A8, as the latter would require a different binary pattern. Instead, the correct subsequent serialization that matches the expected pattern is1111010010100100
, which corresponds to F4A4.I have conducted experiments and confirmed that the compiled FIFT code for the contract indeed results in the opcode F4A4, not F4A8. This change is crucial for maintaining the accuracy and consistency of the whitepaper with the actual behavior of the TVM.
Proposed Changes:
This adjustment will ensure that the documentation accurately reflects the serialization process and avoids any confusion for developers working with the TVM.
Additional Notes:
Thank you for considering this important update. I believe it will greatly benefit the community by providing a more reliable and accurate resource.
Best regards,