Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNGooglePlacesViewController.m #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimaportenko
Copy link

fix GMSAutocompleteViewController dark mode colors

resolves #264

fix GMSAutocompleteViewController dark mode colors
@BrandonBoone
Copy link

@tolu360 - Do you need any help with this PR? Testing, etc. I just applied @troublediehard's patch locally and it works great!

Copy link

@aditya2048 aditya2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes line up quite nicely, i have tested it thoroughly in my current project it is working without any issues. Please merge it.

@tolu360
Copy link
Owner

tolu360 commented Jun 15, 2020

Hi @troublediehard, this looks interesting. I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. I would surely take a look. Thank you for your contributions.

@francescov1
Copy link

Any plans to merge this or #264 ? Or is there at least any active forks?

@dimaportenko
Copy link
Author

@francescov1 obviously there are no plans to merge anything in this repo, the last activity was in 2019.
You can take a look at all forks here and pick something works for you.

@francescov1
Copy link

Got it, ended up using the tool you mentioned here, works great thanks!

@ishabhattt
Copy link

ishabhattt commented Jul 19, 2024

**### To fix theming in React Native Google Places Modal IPhone 13+

A detailed description given on how to create custom objective file and attach it to fix the theming in React Native
and get a whole data object as you get from RNGooglePlaces in return like name, address, latitude, longitude etc

LINK TO PR

iphone-light
iphone-dark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS 13.0+ dark mode displays white text color for openAutocompleteModal queries on a light gray background
6 participants