-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RNGooglePlacesViewController.m #267
base: master
Are you sure you want to change the base?
Conversation
fix GMSAutocompleteViewController dark mode colors
@tolu360 - Do you need any help with this PR? Testing, etc. I just applied @troublediehard's patch locally and it works great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes line up quite nicely, i have tested it thoroughly in my current project it is working without any issues. Please merge it.
Hi @troublediehard, this looks interesting. I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. I would surely take a look. Thank you for your contributions. |
Any plans to merge this or #264 ? Or is there at least any active forks? |
@francescov1 obviously there are no plans to merge anything in this repo, the last activity was in 2019. |
Got it, ended up using the tool you mentioned here, works great thanks! |
**### To fix theming in React Native Google Places Modal IPhone 13+ A detailed description given on how to create custom objective file and attach it to fix the theming in React Native |
fix GMSAutocompleteViewController dark mode colors
resolves #264