Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for flags in function write_at #305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kz2d
Copy link

@kz2d kz2d commented Jun 14, 2024

Hi. I need support for flags in write operation, and implemented it in this PR.

PR implement struct for flags and don't implement all flags.
And then pass this flags on write.

Currently I haven't added tests, so if code is alright I would like too add tests.

@ileixe
Copy link

ileixe commented Jun 14, 2024

You don't have to add new API for setting flag as it can be added in Unsubmit struct.

But if it's added in there, I found exposing flag to user may lead to unsafe behavior (e.g. linked op should be submitted at once). So I think here, we at least make the set_flag API unsafe.

@kz2d
Copy link
Author

kz2d commented Jun 17, 2024

Hi I have added options to set flags on UnsubmittedOneshot like you have said and made it unsafe.

Copy link

@ileixe ileixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think you don't have to redefine flags as io-uring crates already defined it.

We've used custom set_flag() in our project so I think the change would be fine to us at least, but not sure how others think of it.

@kz2d
Copy link
Author

kz2d commented Jun 24, 2024

Hi, can you look at PR, please.

@kz2d
Copy link
Author

kz2d commented Jul 1, 2024

Hi. Any help here?

@ileixe
Copy link

ileixe commented Jul 1, 2024

Hm.. unfortunately, I think nobody currently maintains this repo for now. @ollie-etl is the only one that I know responding. Any advice ollie?

@ollie-etl
Copy link
Contributor

I've the same frustration. The repo is dead, as far as I can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants