-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add support for flags in function write_at #305
base: master
Are you sure you want to change the base?
Conversation
You don't have to add new API for setting flag as it can be added in Unsubmit struct. But if it's added in there, I found exposing flag to user may lead to unsafe behavior (e.g. linked op should be submitted at once). So I think here, we at least make the set_flag API unsafe. |
Hi I have added options to set flags on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think you don't have to redefine flags as io-uring crates already defined it.
We've used custom set_flag() in our project so I think the change would be fine to us at least, but not sure how others think of it.
Hi, can you look at PR, please. |
Hi. Any help here? |
Hm.. unfortunately, I think nobody currently maintains this repo for now. @ollie-etl is the only one that I know responding. Any advice ollie? |
I've the same frustration. The repo is dead, as far as I can tell |
Hi. I need support for flags in write operation, and implemented it in this PR.
PR implement struct for flags and don't implement all flags.
And then pass this flags on write.
Currently I haven't added tests, so if code is alright I would like too add tests.