Update BufResult<T, B> to be Result<(T,B), BufError<B>>
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maaarcocr
changed the title
BufResult<T, B> to be Result<(T,B), BufError<B>>
ollie-etl
approved these changes
Apr 25, 2023
ollie-etl
added a commit
to etlsystems/tokio-uring
that referenced
this pull request
Oct 2, 2023
Merge an updated verions of tokio-rs#267
ileixe
approved these changes
Jan 30, 2024
|
Updated in #295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Solves #178
How?
I've changed the type to be what was proposed in the issue and then followed the compiler warnings to make rustc happy.
I've also added a free function
map_bufwhich allows to map a function over the buffer onBufResult. Let me know if that's okay, but it made writing some code easier.