-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add tree-kdl subcommand #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynn
approved these changes
May 12, 2024
lynn
approved these changes
May 12, 2024
OK, went ahead with the denotation (pretty)printing agenda but replaced KDL with JSON with nice type annotations that could be expanded into stubs later down the line. Also made the printing pretty because that’s what we deserve here at kuna HQ: [ { "claim": { "apply": { "constant": "assert" },
"to": { "lambda": "s0",
"body": { "claim": { "some": "v0",
"body": { "infix": "and",
"left": { "infix": "subinterval",
"left": { "apply": { "constant": "temporal_trace" },
"to": { "variable": "v0" } },
"right": { "variable": "i1" } },
"right": { "verb": "taı",
"args": [ { "constant": "ji" },
{ "variable": "e0" } ],
"event": { "variable": "v0" },
"world": { "variable": "s0" } } } },
"presupposing": { "some": "v0",
"body": { "infix": "and",
"left": { "infix": "subinterval",
"left": { "apply": { "constant": "temporal_trace" },
"to": { "variable": "v0" } },
"right": { "variable": "i0" } },
"right": { "verb": "raı",
"args": [ { "variable": "e0" } ],
"event": { "variable": "v0" },
"world": { "variable": "s0" } } } } } } },
"presupposing": { "some": "v0",
"body": { "infix": "and",
"left": { "infix": "subinterval",
"left": { "apply": { "constant": "temporal_trace" },
"to": { "variable": "v0" } },
"right": { "constant": "speech_time" } },
"right": { "infix": "and",
"left": { "infix": "equals",
"left": { "apply": { "apply": { "constant": "agent" },
"to": { "variable": "v0" } },
"to": { "constant": "real_world" } },
"right": { "constant": "ji" } },
"right": { "verb": "nıka",
"args": [ { "variable": "e0" } ],
"event": { "variable": "v0" },
"world": { "constant": "real_world" } } } } } } ] |
lynn
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, and it looks nice too:
(One thing that I'm not very fond of here is how the leaf nodes are quoted – the KDL spec does not require this but kdljs won't consider whether a value can be left unquoted, unlike with identifiers for example. Might PR this since the library appears nascent.)
(edit for posterity: the spec does in fact require these to be quoted, so it’s all fine)