Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not source orphaned sh files #61

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

windowsrefund
Copy link
Contributor

I have the tinty_source_shell_theme function defined in my environment which runs each time I start a shell.

After noticing some oddness with my shell colors, I decided to poke around in the directory used to store the .sh files which are sourced by the function above. That's when I noticed an orphan:

> ls -go .local/share/tinted-theming/tinty/*.sh
-rw-rw-r-- 1 5102 Sep 15 18:00 .local/share/tinted-theming/tinty/base16-shell-scripts-file.sh
-rw-rw-r-- 1  428 Sep 24 23:14 .local/share/tinted-theming/tinty/tinted-fzf-sh-file.sh
-rw-rw-r-- 1 5109 Sep 24 23:14 .local/share/tinted-theming/tinty/tinted-shell-scripts-file.sh

I'm thinking I mucked something up along the way as I've been tweaking config. Regardless of how it happened, that base16-shell-scripts-file.sh script is an obvious orphan which should no longer be sourced. Here's what I'm doing to overcome the issue.

@windowsrefund windowsrefund requested a review from a team as a code owner September 25, 2024 04:14
@windowsrefund windowsrefund requested review from JamyGolden and removed request for a team September 25, 2024 04:14
@windowsrefund
Copy link
Contributor Author

ah ha, the orphaed file was created as a result of 2141665

Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is related to #33. Once that feature exists, we could run a tinty clean before the tinty init and it should clean things up, however this is still a valuable change.

I've added suggested edits to change shell back to sh because sh gives the markdown code block syntax highlighting, as far as I can see shell isn't supported at all: https://github.com/github-linguist/linguist/blob/main/lib/linguist/languages.yml#L282 which gets mapped to https://github.com/ajaxorg/ace/blob/master/src/mode/sh.js

USAGE.md Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
@JamyGolden JamyGolden merged commit b1e73dd into tinted-theming:main Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants