Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: #253

Merged

Conversation

jacobweinstock
Copy link
Member

Description

The impetus for this change is that there is a bug fix in bmclib for ISO mounting against some Supermicro systems.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The impetus for this change is that there is a bug fix
in bmclib for ISO mounting against some Supermicro
systems.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.78%. Comparing base (a0d1600) to head (1cb7c9d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
controller/client.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   47.91%   47.78%   -0.14%     
==========================================
  Files          11       11              
  Lines        1081     1084       +3     
==========================================
  Hits          518      518              
- Misses        508      511       +3     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes a gosec issue with int to uint32
overflow possibility.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 6180ef3 into tinkerbell:main Oct 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant