Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let users customize aspect ratio of charts #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erdostom
Copy link
Contributor

@erdostom erdostom commented Jan 7, 2020

again, something to scratch my own itch. Maybe it can help with #41 .

Thank you!!

@timqian
Copy link
Owner

timqian commented Jan 10, 2020

Thanks for the PR @erdostom

I tried to change the heightRatio to 1 and the graph seems not right. (Haven't get the chance to debug it)

Screen Shot 2020-01-10 at 3 17 38 PM

Besides, do you think aspectRatio might be a better option name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants