Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override stroke-dasharray attribute in XY chart if option has dataLineDashes #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d3m3vilurr
Copy link
Contributor

@d3m3vilurr d3m3vilurr commented Sep 4, 2019

this pr is just proposal.
I need this option for personal reason. similar option in line & xy charts would help to make the chart

@timqian
Copy link
Owner

timqian commented Sep 4, 2019

Hi @d3m3vilurr I am happy to add this option as long as the graph looks OK when dashed. Do you have an example showing how it looks?

I will keep this PR open for a while to see if others like this option

@d3m3vilurr
Copy link
Contributor Author

firefox_2019-09-04_21-27-35

here is the my sample. I want to draw burndown chart using this lib.

options is

{
  xTickCount: 5,
  yTickCount: 5,
  showLine: true,
  legendPosition: chartXkcd.config.positionType.upRight,
  timeFormat: 'MM/DD',
  dataColors: ['lightgray', '#dd4528', '#28a3dd', '#f3db52'],
  dataLineDashes: ['5 5'],
  dotSize: 0.3,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants